Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(wallet-dashboard): add settings menu and network switcher #4509

Merged
merged 7 commits into from
Dec 18, 2024
Merged

feat(wallet-dashboard): add settings menu and network switcher #4509

merged 7 commits into from
Dec 18, 2024

Conversation

brancoder
Copy link
Contributor

Description of change

closes #4489

@brancoder brancoder added tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp labels Dec 16, 2024
@brancoder brancoder requested a review from a team as a code owner December 16, 2024 14:59
@begonaalvarezd begonaalvarezd changed the title feat(dashboard): add settings menu and network switcher feat(wallet-dashboard): add settings menu and network switcher Dec 16, 2024
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d67bdde

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-qwa2q6yb6.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 5b7528f

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-25olacffh.vercel.app

@evavirseda evavirseda mentioned this pull request Dec 17, 2024
Closed
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d5c1c60

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-gvfrkw63p.vercel.app

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 1fec5c7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-mg7c88j7z.vercel.app

begonaalvarezd
begonaalvarezd requested changes Dec 18, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

beautiful work, just 2 nits

apps/wallet-dashboard/app/(protected)/components/top-nav/TopNav.tsx Outdated
<ConnectButton size="md" />
<Button
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i would put the settings icon the last element

apps/wallet-dashboard/components/Dialogs/settings/enums/view.enums.ts Outdated Show resolved Hide resolved
@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: 07c42ec

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-6dfatgl8m.vercel.app

begonaalvarezd
begonaalvarezd reviewed Dec 18, 2024
View reviewed changes
Copy link
Member

@begonaalvarezd begonaalvarezd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are conflicts too 🙏🏼

@github-actions GitHub Actions
Copy link
Contributor

This pull request has been deployed to Vercel.

Latest commit: d62d9a7

✅ Preview: https://wallet-dashboard-a225fcfa1e2f852205a61a7cd1d5d93e92-parq254a0.vercel.app

@cpl121 cpl121 merged commit a0d25ff into develop Dec 18, 2024
34 of 35 checks passed
@cpl121 cpl121 deleted the tooling-dashboard/add-network-switcher branch December 18, 2024 10:12
miker83z pushed a commit that referenced this pull request Dec 20, 2024
@brancoder @miker83z
feat(wallet-dashboard): add settings menu and network switcher (#4509)
39bf157 
* feat: add settings menu and network switcher

* fix: reset react queries

* fix: change notifications for toast

* fix: view enums and icon ordering in top nav
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cpl121 cpl121 cpl121 approved these changes

@evavirseda evavirseda evavirseda approved these changes

@begonaalvarezd begonaalvarezd begonaalvarezd approved these changes

Assignees
No one assigned
Labels
tooling Issues related to the Tooling team wallet-dashboard Issues related to the Wallet Dashboard dApp
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add network switcher
4 participants
@brancoder @begonaalvarezd @evavirseda @cpl121